Hi Naba,

I recall that we last time decided against blocking it because we agreed
that the test suite was too flaky at the time. It's my understanding that
it has only gotten more flaky. I hope we can see an effort soon to
remediate that and at that point revisit the topic.

I don't have a strong opinion on blocking the button till tests are
completed. Given the noise in the test suite, I'd expect someone who now
merges without waiting, to merge without taking a close look at failed
tests. So to me the place to get to is the reliable test suite.


On Fri, Oct 18, 2019 at 11:48 AM Nabarun Nag <n...@apache.org> wrote:

> Hi devs,
>
> A few months ago a proposal was brought up regarding blocking the merge
> button on the github PR page in case of failing tests in the precheck.
>
> What is the sentiment regarding this now? Do we feel that it should be
> implemented?
>
> Or at least take the minimal step of not allowing merge till all tests are
> done?
>
>
> Regards
> Nabarun Nag
>

Reply via email to