Okay I'm convinced we're okay, so switching to a +1. Standard PEBKAC error here, I managed to produce a native client build which was missing the jar file we use for a whole bunch of tests, so all failed.
Thanks, Blake On Wed, Oct 16, 2019 at 1:03 PM Blake Bender <bben...@pivotal.io> wrote: > I'm a -1 on this one, for the time being, sorry. I ran native client > integration tests against it on my dev workstation and am seeing an > inordinate number of failures. It's gonna take me some time to understand > what's going on, but I'll update everyone shortly as to whether I think we > have a real issue. > > Thanks, > > Blake > > > On Tue, Oct 15, 2019 at 3:29 PM Udo Kohlmeyer <u...@apache.com> wrote: > >> Hi there Owen, >> >> Whilst I share your concern of consistence, the Geode user community did >> not notice that the artifacts changed from war -> jar (GEODE-7241). The >> Spring Data Geode project is currently the only downstream project which >> discovered this regression. >> >> As Spring Data Geode 2.2 will not be using any other version than 1.9.x, >> there is no dependency on 1.10. >> >> In addition to this, 1.11 is not that far off, and upon discovery of >> this regression from 1.9.2 -> 1.10, we most likely could be pointing >> them at 1.11 to upgrade. >> >> As for Spring 5 (GEODE-7261), I might agree that we might want to be >> adding that to 1.10.1 patch, but so far I have not seen/heard of any >> users hitting this issue. Maybe it would also fall into the category of >> "wait for 1.11". >> >> --Udo >> >> On 10/15/19 3:05 PM, Owen Nichols wrote: >> > I am concerned that this 1.9.2 release contains features that are not >> in 1.10: >> > GEODE-7241 Publish war artifacts for geode-web , geode-web-api and >> geode-web-management to Maven Central. >> > GEODE-7261 Fix compatibility with launching geode-web (admin REST API) >> when Spring 5.x jars are on the classpath. >> > >> > My concern is that users of these 1.9.2 fixes will be surprised to >> experience a regression when they upgrade to 1.10.0. >> > >> > This could be addressed by planning a 1.10.1 patch release, or maybe >> just by documenting this caveat as long as the Spring Data project can >> agree to skip over 1.10, but my non-binding vote is -1 until some plan is >> in place. >> > >> > -Owen >> > >> >> On Oct 15, 2019, at 10:47 AM, Jens Deppe <jensde...@apache.org> wrote: >> >> >> >> Hello Geode Dev Community, >> >> >> >> This is a release candidate for Apache Geode version 1.9.2.RC1. >> >> Thanks to all the community members for their contributions to this >> release! >> >> >> >> Please do a review and give your feedback, including the checks you >> >> performed. >> >> >> >> Voting deadline: >> >> 3PM PST Sun, October 20 2019. >> >> >> >> Please note that we are voting upon the source tag: >> >> rel/v1.9.2.RC1 >> >> >> >> Release notes: >> >> >> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.9.2 >> >> >> >> Source and binary distributions: >> >> https://dist.apache.org/repos/dist/dev/geode/1.9.2.RC1/ >> >> >> >> Maven staging repo: >> >> https://repository.apache.org/content/repositories/orgapachegeode-1060 >> >> >> >> GitHub: >> >> https://github.com/apache/geode/tree/rel/v1.9.2.RC1 >> >> https://github.com/apache/geode-examples/tree/rel/v1.9.2.RC1 >> >> https://github.com/apache/geode-native/tree/rel/v1.9.2.RC1 >> >> >> >> Pipelines: >> >> >> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-9-2-main >> >> >> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-9-2-rc >> >> >> >> Geode's KEYS file containing PGP keys we use to sign the release: >> >> https://github.com/apache/geode/blob/develop/KEYS >> >> >> >> Command to run geode-examples: >> >> ./gradlew -PgeodeReleaseUrl= >> >> https://dist.apache.org/repos/dist/dev/geode/1.9.2.RC1 >> -PgeodeRepositoryUrl= >> >> https://repository.apache.org/content/repositories/orgapachegeode-1060 >> >> build runAll >> >> >> >> Regards >> >> --Jens >> > >> >
