Bundling "all" dependencies in a WAR file is a rather subjective topic since, typically, in practice developers did not bundle things like JDBC drivers in a WAR file for their Web app. Common practice was to put "shared" libs in the Servlet Containers global libs directory (using the Common ClassLoader) for shared consumption by all Web apps, for better or worse.
WAR files (like JAR and EAR) are based on "format" (e.g. containing a WEB-INF/web.xml file, with WEB-INF/classes of the app and possibly libs in WEB-INF/lib), not simply just deps. As such, by following this format, the container will consider this a "valid" WAR file. However, if we are just basing it on libs, then none of the WAR files are valid by that definition (not even Pulse) because none contain the necessary Apache Geode libs (e.g. geode-core). Therefore, none of the WAR files could stand on their own, not even Pulse. On Wed, Sep 25, 2019 at 8:17 AM Udo Kohlmeyer <u...@apache.com> wrote: > Seems these should have been Jars all along... > > On 9/24/19 8:09 PM, Jacob Barrett wrote: > > Why publish them as WAR files at all? As they are currently packaged > they can't be deployed in just any J2EE web container because they lack all > the dependencies. Sure they look like WAR files internally but they are > really modules that expect to run in and only in the Geode server. > Publishing them as a WAR file gives the false impression that they can be > consumed by any project as a full fledged WAR. > > > > We should make up our own JAR spec based on WAR, perhaps calling it > Geode Web ARchive or GWAR for short. Yes, I just went there… GWAR!!! > 🤘🎸🤘🎸🤘🎸🤘🎸 > > > > But seriously, unless it can be deployed in any J2EE web container it > shouldn’t be considered a WAR. > > > > -Jake > > > >> On Sep 24, 2019, at 3:34 PM, Robert Houghton <rhough...@pivotal.io> > wrote: > >> > >> I am working on the change to get the geode-web and geode-web-api war > >> artifacts published instead of the jars. I have found the > >> geode-web-management project is also producing a war artifact, in > addition > >> to a jar. Do we want it to be published as well? What is the criterion > we > >> use to decide? > >> > >> I think this problem was an oversight from the changes PurelyApplied > and I > >> made to the build when we made the publish plugin 'opt-in' instead of > >> forced by the root project. Easy to publish one or the other, but I am > not > >> qualified to decide whether a war or jar is more appropriate for these > >> modules. > >> > >> Thank you, > >> -Robert > -- -John john.blum10101 (skype)
