FWIW, I don't think 1.9.1 clients (or any combination of patch versions) should be incompatible with servers 1.9.patch-1 (e.g. 1.9.0). IMO, that would be very bad!
major.minor client/servers, regardless of patch versions, should remain interoperable. On Thu, Aug 29, 2019 at 11:41 AM Owen Nichols <onich...@pivotal.io> wrote: > 1.9.1 was added to 1.10 and develop as well, so will need to be reverted > everywhere and will not be able to do the 1.10.0 RC1 today > > > On Aug 29, 2019, at 11:35 AM, Dan Smith <dsm...@pivotal.io> wrote: > > > > From my reading, bumping the ordinal in 1.9.1 will make 1.9.1 > incompatible > > with 1.10, unless we also fix 1.10 to know about 1.9.1's ordinal. It will > > also make 1.9.1 clients incompatible with 1.9.0 servers, which may not be > > desired? > > > > I guess we just need to settle on a process. It sounds like maybe the > > process should be always bump on minor releases, but don't bump the > version > > on patch releases unless we really need to change the protocol for a > patch > > release. Previous geode patch releases (1.2.1, 1.1.1) did not change > > Version.java. If that's the case, I think we should go ahead and revert > the > > changes to Version.java for 1.9.1 and create a new RC. > > > > -Dan > > > > On Thu, Aug 29, 2019 at 10:35 AM Anthony Baker <aba...@pivotal.io> > wrote: > > > >> I see there’s a VOTE thread for 1.9.1. Do you suggest to -1 that > release > >> candidate? > >> > >> Anthony > >> > >> > >>> On Aug 29, 2019, at 8:53 AM, Bruce Schuchardt <bschucha...@pivotal.io> > >> wrote: > >>> > >>> I also missed this vote email. Dan is right that creating the v1.9.1 > >> Version instance was unnecessary. I don't think it hurts anything per > se > >> but it does unnecessarily consume a serialization version ordinal. That > >> will leave us with only 3 (102, 103 and 104) if we *ever* need to issue > >> more 1.9 patches. I recommend removing that Version and leaving the > >> serialization version at 1.9.0 for this release. > >>> > >>> On 8/28/19 2:51 PM, Dan Smith wrote: > >>>> I missed this vote email as well - if we reopen the vote I'll cast > one. > >> I > >>>> don't really have much context on why we want a 1.9.1 but I'm happy to > >>>> double check the bits. > >>>> > >>>> One comment on this RC - I noticed that we bumped the ordinal in > >>>> Version.java - is that what we actually want to do? That implies a new > >>>> version of our communications protocol, which 1.10 will have to > >> understand. > >>>> Did we actually change the communication protocol in this release? > >>>> > >>>> -Dan > >>>> > >>>> On Wed, Aug 28, 2019 at 2:42 PM Kirk Lund <kl...@apache.org> wrote: > >>>> > >>>>> SBDG 1.2 is currently in RC and cannot be changed to depend on Geode > >> 1.10. > >>>>> It must depend on Geode 1.9 or 1.9.1. > >>>>> > >>>>> So if we want to provide the logging fixes for SBDG 1.2 then we must > >>>>> release Geode 1.9.1. > >>>>> > >>>>> Let's open a new vote for releasing Geode 1.9.1. > >>>>> > >>>>> On Wed, Aug 28, 2019 at 1:37 PM Owen Nichols <onich...@pivotal.io> > >> wrote: > >>>>> > >>>>>> It's past the announced deadline and the vote has failed to due to > >> lack > >>>>> of > >>>>>> quorum. > >>>>>> > >>>>>> Voting status > >>>>>> ========== > >>>>>> +1: zero votes > >>>>>> > >>>>>> +0: zero votes > >>>>>> > >>>>>> -0: zero votes > >>>>>> > >>>>>> -1: zero votes > >>>>>> > >>>>>> The voting does not meet the requirements < > >>>>>> https://www.apache.org/foundation/voting.html> of at least 3 PMC > >> members > >>>>>> with +1 votes and a majority of +1 votes. > >>>>>> > >>>>>> The matter of what to do next is referred back to the original > DISCUSS > >>>>>> thread that proposed 1.9.1. > >>>>>> > >>>>>> -Owen & Kirk > >>>>>> > >>>>>>> On Aug 22, 2019, at 6:10 PM, Owen Nichols <onich...@pivotal.io> > >> wrote: > >>>>>>> > >>>>>>> Hello Geode dev community, > >>>>>>> > >>>>>>> This is a release candidate for Apache Geode, version 1.9.1.RC1. > >>>>>>> Thanks to all the community members for their contributions to this > >>>>>> release! > >>>>>>> Please do a review and give your feedback. The deadline is 3PM PST > >> Tue, > >>>>>> August 27 2019. > >>>>>>> Release notes can be found at: > >>>>> > >> > https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.9.1 > >>>>>> < > >>>>>> > >>>>> > >> > https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.9.1 > >>>>>> > >>>>>>> Please note that we are voting on the source tag: rel/v1.9.1.RC1 > >>>>>>> > >>>>>>> Apache Geode: > >>>>>>> https://github.com/apache/geode/tree/rel/v1.9.1.RC1 < > >>>>>> https://github.com/apache/geode/tree/rel/v1.9.1.RC1> > >>>>>>> Apache Geode examples: > >>>>>>> https://github.com/apache/geode-examples/tree/rel/v1.9.1.RC1 < > >>>>>> https://github.com/apache/geode-examples/tree/rel/v1.9.1.RC1> > >>>>>>> Apache Geode native: > >>>>>>> https://github.com/apache/geode-native/tree/rel/v1.9.1.RC1 < > >>>>>> https://github.com/apache/geode-native/tree/rel/v1.9.1.RC1> > >>>>>>> Source and binary files: > >>>>>>> https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC1/ < > >>>>>> https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC1/> > >>>>>>> Maven staging repo: > >>>>>>> > >> https://repository.apache.org/content/repositories/orgapachegeode-1055 > >>>>> < > >>>>>> > >> https://repository.apache.org/content/repositories/orgapachegeode-1055> > >>>>>>> Geode's KEYS file containing PGP keys we use to sign the release: > >>>>>>> https://github.com/apache/geode/blob/develop/KEYS < > >>>>>> https://github.com/apache/geode/blob/develop/KEYS> > >>>>>>> PS: Command to run geode-examples: ./gradlew -PgeodeReleaseUrl= > >>>>>> https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC1 < > >>>>>> https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC1> > >>>>>> -PgeodeRepositoryUrl= > >>>>>> > >> https://repository.apache.org/content/repositories/orgapachegeode-1055 > < > >>>>>> > >> https://repository.apache.org/content/repositories/orgapachegeode-1055> > >>>>>> build runAll > >>>>>>> Regards > >>>>>>> Owen Nichols & Kirk Lund > >>>>>>> > >>>>>> > >> > >> > > -- -John john.blum10101 (skype)
