Thanks Naba. I couldn't get this test to pass. Anyways if it still counts +1 for the release. I am okay to release native code if the version doesn't default to 1.8.0 as we are not including binaries.
Sai On Tue, Dec 11, 2018 at 7:15 AM Jacob Barrett <jbarr...@pivotal.io> wrote: > The java bits generate a property file that goes in the source release > that encapsulates all the version info. Maybe native should too. > > > On Dec 11, 2018, at 6:47 AM, Ernest Burghardt <eburgha...@pivotal.io> > wrote: > > > > If the community desires the default dev version to match the release, > > let's file a JIRA and change this... anyone else have an opinion on this > > default version? > > Thanks! > > EB > > > >> On Mon, Dec 10, 2018 at 10:28 PM Jacob Barrett <jbarr...@pivotal.io> > wrote: > >> > >> -0 > >> > >> I don’t think a user should have to specify a version when building the > >> source release of geode-native. If you don’t specify a version it > defaults > >> to the development version of 0.0.42. It should probably default to the > >> source release version. > >> > >> Outside of that issue the native sources build as expected. > >> > >> -Jake > >> > >> >
