+1 I added my approval to your PRs. I don't know if the yml is correct or
not, but I support the overall goal.

On Thu, Nov 8, 2018 at 1:19 PM, Owen Nichols <onich...@pivotal.io> wrote:

> Sounds like the overwhelming consensus is to keep Java11 gating, add
> Java11 to PR, and defer non-gating tests.
>
> I have prepared PRs for these changes:
> https://github.com/apache/geode/pull/2806 (add Java11 to PR pipeline)
> https://github.com/apache/geode/pull/2816 (run non-gating jobs only after
> gating jobs have passed)
>
> Please review and merge.
>
> Thanks,
> -Owen
>
> > On Nov 8, 2018, at 9:41 AM, Patrick Rhomberg <prhomb...@pivotal.io>
> wrote:
> >
> > I agree with Jinmei on all points.  I definitely think there should be
> > parity between precheckin and the main pipeline, but that might just be
> > because I caused the main pipeline to fail on Java11 this week.
> >
> > On Wed, Nov 7, 2018 at 1:34 PM, Jinmei Liao <jil...@pivotal.io> wrote:
> >
> >> First of all, I believe all gating tests should be run in precheckin.
> If we
> >> make jdk11 tests gating, we should make it part of the precheckin. If we
> >> don't put them in precheckin, they should not be gating.
> >>
> >> Secondly, If we don't make jdk11 tests gating, soon they will become
> like
> >> windows tests, people only look at them after it's been failing for
> days,
> >> which is not good.
> >>
> >> Thirdly, for non-gating tests, we probably should run them after all the
> >> gating tests are done.
> >>
> >> On Wed, Nov 7, 2018 at 11:39 AM Owen Nichols <onich...@pivotal.io>
> wrote:
> >>
> >>> Now that tests are passing under Java 11, it was recommended last week
> to
> >>> make Java 11 tests gating for the develop pipeline.  [Fyi, Windows
> tests
> >>> are not yet gating, meaning the pipeline will success and publish
> >> artifacts
> >>> even if a Windows tests fails.]
> >>>
> >>> Three topics merit discussion:
> >>>
> >>> 1) For the Geode 1.8 release, should the release notes advertise
> >>> “experimental support for Java 11” or no support?  If the latter,
> should
> >>> Java 11 tests still be gating on the 1.8 release branch, or only on
> >> develop?
> >>>
> >>> 2) As of now, pre-checkin runs tests only against Java8.  Now that
> Java11
> >>> is gating in develop, should we now be testing against both Java8 and
> >>> Java11 as part of validating pull requests?
> >>>
> >>> 3) In the develop pipeline, should non-gating jobs continue to be run
> in
> >>> parallel with gating jobs?  Or would it be better to change the develop
> >>> pipeline to only run the non-gating tests after all gating jobs have
> >> passed?
> >>>
> >>> Thanks,
> >>> -Owen
> >>>
> >>> P.S. after a brief trial of combining Java8 and Java11 tests into a
> >> single
> >>> pipeline job, that was reverted and it looks like separate jobs are
> here
> >> to
> >>> stay.  Combined jobs made it difficult to look at dual scrolling
> outputs
> >>> and dual archive-results steps.  If you feel there’s a better solution,
> >>> please speak up.
> >>>
> >>>
> >>
> >> --
> >> Cheers
> >>
> >> Jinmei
> >>
>
>

Reply via email to