+1 assuming “all of the PR checks” will soon include Java 11 Implementation-wise should be as simple at getting someone with admin privileges on the geode repo to change the settings for “develop” branch to "Require status checks to pass before merging."
> On Nov 9, 2018, at 12:58 PM, Robert Houghton <rhough...@pivotal.io> wrote: > > +1 > > On Fri, Nov 9, 2018, 12:55 Dan Smith <dsm...@pivotal.io wrote: > >> Hi all, >> >> Kirks emails reminded me - I think we are at the point now with our PR >> checks where we should not be merging anything to develop that doesn't pass >> all of the PR checks. >> >> I propose we disable the merge button unless a PR is passing all of the >> checks. If we are in agreement I'll follow up with infra to see how to make >> that happen. >> >> This would not completely prevent pushing directly to develop from the >> command line, but since most developers seem to be using the github UI, I >> hope that it will steer people towards getting the PRs passing instead of >> using the command line. >> >> Thoughts? >> -Dan >>
