The gfsh command 'upgrade offline-disk-store' exists in the code in order to upgrade diskstores from pre-Apache days (GemFire 6.x and 7.x).
I don't believe the command is relevant/necessary anymore and, unless there are objections, I'd like to go ahead and remove it. --Jens