----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62132/#review184852 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java Line 1099 (original), 1092 (patched) <https://reviews.apache.org/r/62132/#comment261049> Do you think there is any value in logging the full stacktrace of the exception? It looks like that never gets logged anywhere. - Jared Stewart On Sept. 6, 2017, 8:10 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62132/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 8:10 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > Updated tests for changes in the error constructors for ServerState and > LocatorState. > > Minor spelling corrections. > > This reintroduces changes that were reverted due to merge conflicts with > the previous state of the develop branch > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > 83c1ab533e3dea323a8a99f7002b9464a54dfc25 > geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java > ae64691605130c9b212a3a33bb65ae37b28af02b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java > 72ccfbbc83b18e8bc32759dbeabaf2f9ef4c2f45 > > geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java > 409a96dbe416a6f96c2389356b9d823d1adb793f > > geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalIntegrationTest.java > 9fce94e89a369094a2383eb9103f2f43a8ff3013 > > geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java > cc42a53772f3064b800ca1ac1ae894be6c715399 > > geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherLocalIntegrationTest.java > 29ddaaf6692565a9afb8c528790b35798d118a31 > > geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTest.java > 733a1082ae9993fbdb646712380af7dcc1cca560 > > geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java > 2bcd994d4d14888adfdf68abef5acbc068b6fea8 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > a9ce889006800523505dace6e0b4696c9911d205 > > > Diff: https://reviews.apache.org/r/62132/diff/1/ > > > Testing > ------- > > Precheckin is green > > > Thanks, > > Ken Howe > >
