----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62002/#review184275 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/CommandResult.java Lines 632 (patched) <https://reviews.apache.org/r/62002/#comment260405> See Gfsh.handleExecutionResult.... any chance this could be called before gfsh gets the result for display? If so, then gfsh will display nothing, since hasNextLine() will return false from now on. Maybe for now just add a comment there saying only call this after gfsh displays the result already. The whole gfsh result displayer is a mess for now. - Jinmei Liao On Aug. 30, 2017, 10:13 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62002/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 10:13 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3539: Add tests for List Members and Describe Member > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMemberCommand.java > ea88c69ebdd2ce5ffbab486fcb7a4dda71935586 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/result/CommandResult.java > bbb59d0755ffd2cf405f78c89b420a5279844e29 > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/MemberCommandsController.java > ba5c788f90ef68dc8ac338a4619646b4f3608293 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DescribeMembersCommandDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java > fe6bc404d33b48e5384348241c17ccf924f4627c > > geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java > 17719be16338ab9894878660054b75ff9cc6c3ec > > > Diff: https://reviews.apache.org/r/62002/diff/1/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >
