> On Aug. 24, 2017, 9:29 p.m., Kirk Lund wrote: > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java > > Lines 96 (patched) > > <https://reviews.apache.org/r/61860/diff/1/?file=1802513#file1802513line96> > > > > I'm curious, what's the result of this method? Does in interleave > > stdout and stderr in someway? > > > > Another alternative is to use ProcessBuilder.redirectErrorStream so > > they become interleaved chronologically. The downside is you can't > > differentiate between the two. But there's probably some other way to > > synchronize the two chronologically using a stream tee or union.
I'll remove this method for now until I have a better implementation. - Jared ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61860/#review183798 ----------------------------------------------------------- On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61860/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 8:18 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3510: GfshRule displays output from StdError > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java > 47f030471a988055400a71e5b564f3b24397c2e8 > > > Diff: https://reviews.apache.org/r/61860/diff/1/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >