> On Aug. 23, 2017, 9:29 a.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java > > Line 68 (original), 72 (patched) > > <https://reviews.apache.org/r/61829/diff/1/?file=1801929#file1801929line72> > > > > Will this warning be printed every time when we close the socket? > > Bruce Schuchardt wrote: > When the socket is closed we get a null message from Protobuf and > translate that into an EOFException
so, no we won't print this warning. That's the purpose of this change & it is also what the old client interface does. - Bruce ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61829/#review183616 ----------------------------------------------------------- On Aug. 22, 2017, 4:41 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61829/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 4:41 p.m.) > > > Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh > Khamesra, Udo Kohlmeyer, and Brian Rowe. > > > Bugs: GEODE-3408 > https://issues.apache.org/jira/browse/GEODE-3408 > > > Repository: geode > > > Description > ------- > > Modified the message handler to catch EOFException and effect shutdown of the > connection & server thread. I also fixed the handling of IOException. > > The methods invoked are the same as for the old protocol's handling of > EOFException and IOException. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java > cd1647a > > > Diff: https://reviews.apache.org/r/61829/diff/1/ > > > Testing > ------- > > as this just affects logging behavior there are no new unit tests. I > verified that the behavior is correct with the manual test used to reproduce > GEODE-3409 (my other review that is currently open). > > precheckin is running now. > > > Thanks, > > Bruce Schuchardt > >
