----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61694/#review183167 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On Aug. 17, 2017, 8:21 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61694/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2017, 8:21 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3235: Deploy jar registers functions which extend FunctionAdapter > - Extract FunctionScanner class > - Add scanning for FunctionAdapter in addition to Function > - Add test to expose GEODE-3429 > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java 037ef9e > > geode-core/src/main/java/org/apache/geode/management/internal/deployment/FunctionScanner.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandFunctionRegistrationDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/deployment/FunctionScannerTest.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractExtendsFunctionAdapter.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractImplementsFunction.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AnnotatedFunction.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractExtendsFunctionAdapter.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractImplementsFunction.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsAbstractFunction.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsFunctionAdapter.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ImplementsFunction.java > PRE-CREATION > geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java > beea476 > geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java > 8449605 > > > Diff: https://reviews.apache.org/r/61694/diff/2/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jared Stewart > >
