----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61599/#review182758 -----------------------------------------------------------
Ship it! Replacing hardcoded path strings with system independant constructs is always good. I didn't try this out myself on a Windows machine but the fix looks good. - Ken Howe On Aug. 11, 2017, 10:42 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61599/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2017, 10:42 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3328: fix a test failure on windows. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java > da60c7aa481954be0acc8c7e2b88717cf8bc9c37 > > > Diff: https://reviews.apache.org/r/61599/diff/1/ > > > Testing > ------- > > the test itself since only this test is changed. > > > Thanks, > > Jinmei Liao > >
