Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132306579
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
 ---
    @@ -31,7 +31,7 @@
     import org.apache.geode.internal.admin.remote.DistributionLocatorId;
     import org.apache.geode.internal.i18n.LocalizedStrings;
     import org.apache.geode.internal.logging.LogService;
    -import 
org.apache.geode.internal.process.ClusterConfigurationNotAvailableException;
    +import 
org.apache.geode.config.internal.ClusterConfigurationNotAvailableException;
    --- End diff --
    
    Classic Pat nitpick: don't forget to reorder / optimize your imports to go 
`statics`, `java`, `javax`, (other), `org.apache.geode`.
    
    This applies to the following files:
    ```
    geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java
    
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
    
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
    
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
    
geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java
    
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartServerCommand.java
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to