Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/693#discussion_r131775864
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DescribeRegionCommand.java
---
@@ -333,9 +247,8 @@ private void
writeCommonAttributesToTable(TabularResultData table, String attrib
}
}
- private boolean writeFixedPartitionAttributesToTable(TabularResultData
table,
- String attributeType, List<FixedPartitionAttributesInfo> fpaList,
String member,
- boolean isMemberNameAdded) {
+ private void writeFixedPartitionAttributesToTable(TabularResultData
table,
--- End diff --
In this function, a couple of low-hanging cleanups could be:
(1) Change the big `if` to a guard clause
```
if (fpaList == null) {
return;
}
```
(2) Change the iterated `while` loop to a `for:` loop.
Also, both of these can be cleanly easily handled by your IDE (although you
might need to move the `Iterator<FixedPartitionAttributesInfo> fpaIter =
fpaList.iterator();` next to the `while` first).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
