----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61411/#review182216 -----------------------------------------------------------
Ship it! Ship It! - Bruce Schuchardt On Aug. 3, 2017, 4:01 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61411/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2017, 4:01 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Udo Kohlmeyer, and Brian Rowe. > > > Repository: geode > > > Description > ------- > > In previous fix, we were checking "if thread is stopped then add connection > to receiver list". Instead, it should be if thread is stopped then we should > not add connection to receiver list. As a fix, we add connection to reciver > list if connection is not closed or thread is not stopped. > > Added unit for it. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java > c3ad596 > geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java > 69fb7a2 > > geode-core/src/test/java/org/apache/geode/internal/tcp/ConnectionTableTest.java > 312c64d > > > Diff: https://reviews.apache.org/r/61411/diff/2/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
