Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/671#discussion_r131002611
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
---
@@ -1143,4 +721,26 @@ private boolean
isAttributePersistent(RegionAttributes attributes) {
return attributes != null && attributes.getDataPolicy() != null
&& attributes.getDataPolicy().toString().contains("PERSISTENT");
}
+
+ private static boolean regionExists(InternalCache cache, String
regionPath) {
--- End diff --
Fixed! Thanks for your feedback! Do you mean it would be nice to have a
test that would fail if `regionExists` always returns `true`, regardless of
whether the region does or doesn't exist? I wrote a very simple test that does
this and put it in `CreateRegionCommandTest`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
