----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61143/#review181585 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java Lines 184 (patched) <https://reviews.apache.org/r/61143/#comment257168> The logging is to try to help debugging if it ever failed. Most of the time, those unit test failure are hard to reproduce. It will be better to have enough artifacts saved. You raise a good point of the type of TransactionException. Currently we throw two types of TransactionException if transaction lands on two different nodes -- TransactionDataNodeHasDepartedException and TransactionDataNotColocatedException. However, product does not have enough information to detect in this case if user targets wrong bucket/node (TransactionDataNotColocatedException) or the bucket primary has been moved due to rebalance of node failure. Therefore, the non colocated message is important in this case. geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommandTest.java Lines 64 (patched) <https://reviews.apache.org/r/61143/#comment257171> It will need to have client-server dunit test to test TXFailoverCommand. And it will be hard to trace/track which node to bring down (only has TXStatePeerStub). Also, you can not control which node to failover to in the test -- you need to failover to another server which does not host the TXState. - Eric Shu On July 27, 2017, 5:32 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61143/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 5:32 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, > and Nick Reich. > > > Bugs: GEODE-3310 > https://issues.apache.org/jira/browse/GEODE-3310 > > > Repository: geode > > > Description > ------- > > Set target node in TXStateProxy during TXFailover if necessary > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommand.java > 6bd00c0 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/MyTransactionFunction.java > 0970836 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java > 7a56644 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommandTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61143/diff/2/ > > > Testing > ------- > > Ongoing precheckin. > > > Thanks, > > Eric Shu > >
