Github user WireBaron commented on a diff in the pull request:

    https://github.com/apache/geode/pull/657#discussion_r129683975
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
    @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {
         this.batchFlusher.start();
       }
     
    +  public void onIdleCancel() {
    --- End diff --
    
    We'll change this to cleanUpOnIdleTaskCancel.  The connection will always 
be closed when we reach this code.  We debated adding an assert here, but 
decided against it.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to