GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/652
Geode-2971: Introduce ExitCode to resolve inconsistency of shell exit values
There are a few sections containing `// TODO PSRhomberg`. Most are there
to mark a specific request for feedback, and two are there to explain a change
that counterintuitively respects existing behavior.
- [ ] Have you removed your `TODO` comments?
- [ ] Is your initial contribution a single, squashed commit?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-2971
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/652.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #652
----
commit f8b1685dcecd023bbaa17fec8024dc32af648f33
Author: Patrick Rhomberg <[email protected]>
Date: 2017-07-20T19:36:36Z
Added ExitCode to handle all System.exit calls.
* Significant refactoring of Launcher.java and its use of exit states.
commit 60a1bcd93fe3c4e67d0735b3fce6c9d3bed0d9f6
Author: Patrick Rhomberg <[email protected]>
Date: 2017-07-20T19:40:34Z
All System.exit calls replaced by an appropriate call of
ExitCode.[code].doSystemExit();
commit 57df2484d9a1fc6001dc5ef12522a24483f126f6
Author: Patrick Rhomberg <[email protected]>
Date: 2017-07-20T22:54:06Z
Added AcceptanceTest for gfsh member status commands
commit c82b0115099b98bbbfca1eb6e3539a82e6fe054b
Author: Patrick Rhomberg <[email protected]>
Date: 2017-07-20T19:42:18Z
Correction of inconsistency in exit status of member status commands.
commit 92da642dcf1b5039def0ecf3d0f317c652a48515
Author: Patrick Rhomberg <[email protected]>
Date: 2017-07-21T22:05:48Z
Removed dead code and many needless asides from touched file
SystemFailure.java
commit 830d3ee0af16c765b99271e231377439cd659b26
Author: Patrick Rhomberg <[email protected]>
Date: 2017-07-21T22:15:27Z
Removed redundant declarations and much dead code from touched file
StatArchiveReader.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
