----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61084/#review181240 -----------------------------------------------------------
Ship it! Ship It! - Jared Stewart On July 24, 2017, 4:28 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61084/ > ----------------------------------------------------------- > > (Updated July 24, 2017, 4:28 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > More refactor of the rules > GEODE-3231: withLogFile does not imply withWorkingDir anymore > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java > 721e5020ead8c93313008d11599195a0a0022f9e > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java > 492e304e43113877102be22304bab09025a36dbc > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java > 6726ede5e7a2e9237406d701e8d01c8cbb4adf8b > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java > 557fae7f58d5b7eb29818177c329de255eea75c1 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java > a1dff25990fcf1fd1c41e2e291d4ef277032ba36 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java > 9669669c4fe103ddb21885eca5f23743f75ae005 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java > 4e72444d634ab37d39b3b01018d5f21c6ce67753 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java > 12410c79a3df1624e165ebecf1f97425e1ce08e6 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java > 0cd6d5af65aab3d286267b663418b798da362904 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsDUnitTest.java > 35d65a005198b981581bf7d02476ad79cd0eea9c > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 872553efed290890708caaf98dc206b4735005d0 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > d8753cf285388acabef91761a5043ee18f8475f3 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java > e1c14ce828d45d3777e9b31f4b7019e23d6a19ce > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java > 156236bae5cc1b5dc477b01e8b1955bf4aae64fb > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > 0fd0e7759695d05071a4ade327b129107a9d9d0e > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java > 4970cb5a6becfe259c70132adad949d34f7e2952 > > geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java > 368d64dd9c2be3fb15d6d4563bb1c95d83733244 > > > Diff: https://reviews.apache.org/r/61084/diff/1/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
