----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review180088 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java Lines 96 (patched) <https://reviews.apache.org/r/60666/#comment255106> Deprecated text should mention the release 1st deprecated in and the API that user should use instead. Something like: @deprecated As of Geode 1.3, please use getCredentials(Properties, DistributedMember, boolean) - Kirk Lund On July 6, 2017, 4:03 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60666/ > ----------------------------------------------------------- > > (Updated July 6, 2017, 4:03 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > geode-3166: remove the uncalled getCredential method > > I simply removed the call. Since the new method is never called, if we have > any users that's implementing this method, it's never used anyway. We will > not be breaking backward compatibility, I believe. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java > 6b0675a5629a3e057fd3d54841db740189007966 > > > Diff: https://reviews.apache.org/r/60666/diff/2/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
