----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60664/#review179694 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On July 5, 2017, 7:01 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60664/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 7:01 p.m.) > > > Review request for geode, Barry Oglesby, Hitesh Khamesra, and Dan Smith. > > > Bugs: geode-3153 > https://issues.apache.org/jira/browse/geode-3153 > > > Repository: geode > > > Description > ------- > > The previous fix worked fine for 1.0.0 and 1.1.0 clients but there are old > GemFire 8.2 clients still in use that the fix did not work for. This patch > changes the serialization to always send UUID bytes to pre Version.GFE_90 > (1.0.0-incubating) clients. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java > 85c2bea467b115c4fe5f0ea51ef053d26e300a58 > geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java > 86216497caad3f18debcc6a81182caadc8b7e487 > > > Diff: https://reviews.apache.org/r/60664/diff/1/ > > > Testing > ------- > > Precheckin is under way. Barry gave me a manual test using an 8.2 client > that is now passing. Steps are: > start 1.0.0 locator and server > start 8.x client that registers interest > start 1.2 server > push data using a 1.0.0 peer > kill the 1.0.0 server > --> the client should not see duplicate events > > Hitesh is writing junit tests for the EventID changes. > > > Thanks, > > Bruce Schuchardt > >
