GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/617
GEODE-3129 - Added error messages to protobuf protocol
added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and
refactored operation handlers to instead return ErrorResponses
made all op handlers take ClientProtocol.Requests and return
ClientProtocol.Responses instead of operation specific types
moved the protobuf specific response building code from operation handlers
to ProtobufResponseUtilities
moved the request building functions from MessageUtil (under Test) to
ProtobufRequestUtilities
moved all utility classes to ...protocol.protobuf.utilities and added
javadoc comments throughout
changed GetRegions to GetRegionNames, returns strings instead of Regions
replaced logging through the cache's LogWriter with log4j logging
updated all imports to be in the correct order for the new geode style guide
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WireBaron/geode feature/GEODE-3129
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #617
----
commit 14c142d1853c87932ab58f66e2a0d54d3caf0652
Author: Brian Rowe <br...@pivotal.io>
Date: 2017-07-03T23:01:56Z
GEODE-3129 - Added error messages to protobuf protocol
added a new ErrorResponse type to ClientProtocol
removed success field from several RegionAPI response objects and
refactored operation handlers to instead return ErrorResponses
made all op handlers take ClientProtocol.Requests and return
ClientProtocol.Responses instead of operation specific types
moved the protobuf specific response building code from operation handlers
to ProtobufResponseUtilities
moved the request building functions from MessageUtil (under Test) to
ProtobufRequestUtilities
moved all utility classes to ...protocol.protobuf.utilities and added
javadoc comments throughout
changed GetRegions to GetRegionNames, returns strings instead of Regions
replaced logging through the cache's LogWriter with log4j logging
updated all imports to be in the correct order for the new geode style guide
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
