----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60442/#review179072 -----------------------------------------------------------
Fix it, then Ship it! Fix `AcceptorImpl.this` reference and then ship geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java Line 1457 (original), 1457 (patched) <https://reviews.apache.org/r/60442/#comment253482> What does `AcceptorImpl.this` return? `this` should be enough? - Udo Kohlmeyer On June 26, 2017, 6:31 p.m., Brian Rowe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60442/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 6:31 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-3130 > https://issues.apache.org/jira/browse/GEODE-3130 > > > Repository: geode > > > Description > ------- > > This review addresses Udo's last feedback for GEODE-2995. This change also > cleaned up the imports on the AcceptorImplJUnitTest. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > 50f7006fa > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImplJUnitTest.java > 7aa11b7ca > > > Diff: https://reviews.apache.org/r/60442/diff/1/ > > > Testing > ------- > > Precheckin in progress. > > > Thanks, > > Brian Rowe > >
