----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60375/#review178940 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionFactoryImpl.java Line 82 (original), 82 (patched) <https://reviews.apache.org/r/60375/#comment253281> since we already pass in the entire sys, do we need to pass in sys.getSecurityService() as well? Can we change the signaure of the constructor to take an InternalDistributedSystem, and directly uses the security service inside the passed sys? geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java Line 342 (original), 343 (patched) <https://reviews.apache.org/r/60375/#comment253282> instead of this, can we do this.securityService = sys.getSecurityService()? - Jinmei Liao On June 26, 2017, 6:02 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60375/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 6:02 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-3117 > https://issues.apache.org/jira/browse/GEODE-3117 > > > Repository: geode > > > Description > ------- > > GEODE-3117: fix Gateway authentication with legacy security > > * add GatewayLegacyAuthenticationRegressionTest to reproduce bug > * fix authentication of Gateway sender/receiver with > SECURITY_CLIENT_AUTHENTICATOR > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionFactoryImpl.java > a419d575010d39d4dab6c5c8f9748928c1764344 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java > 32735b9ab17fe9467cea46096bd177902145e4bd > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/GatewayLegacyAuthenticationRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60375/diff/1/ > > > Testing > ------- > > * new test reproduces GEODE-3117: GatewayLegacyAuthenticationRegressionTest > * precheckin passes > > > Thanks, > > Kirk Lund > >
