----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/#review178811 -----------------------------------------------------------
Ship it! LGTM geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java Line 103 (original), 102 (patched) <https://reviews.apache.org/r/60348/#comment253035> Yeah, That's even better than my suggestion! - Ken Howe On June 23, 2017, 6:01 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60348/ > ----------------------------------------------------------- > > (Updated June 23, 2017, 6:01 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > - GfshRule writes via a logger rather than StdOut. This will make it no > longer clutter precheckin runs or the nightly build. > - Introduce ProcessLogger to capture output from the Gfsh JVM so that tests > can assert against the output. > > > Diffs > ----- > > geode-assembly/build.gradle 39bb542 > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java > 82ee240 > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java > 8109377 > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java > 3ee1402 > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/StreamGobbler.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/CommandStringBuilder.java > cfb8a24 > > > Diff: https://reviews.apache.org/r/60348/diff/3/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >
