[
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030207#comment-16030207
]
ASF GitHub Bot commented on GEODE-2203:
---------------------------------------
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119225532
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public Result statusLocator(
CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE,
LOCATOR_TERM_NAME));
}
} else {
- final LocatorLauncher locatorLauncher =
- new
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+ final LocatorLauncher locatorLauncher;
+ if ((locatorHost == null) && (locatorPort == null) &&
(workingDirectory == null)) {
--- End diff --
I think that if a value is given for locatorPort but not for locatorHost,
`locatorLauncher` will just have a null value for locatorPort, with no errors
(in the `else` statement). Do you mean there will be an error in a different
part of the code?
> gfsh status locator/server - Give more descriptive output on empty parameter
> ----------------------------------------------------------------------------
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Alyssa Kim
> Assignee: Emily Yeh
> Priority: Minor
> Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters
> gives a vague explanation/output that might be misleading. Although we have
> help <command_name> for usage description, displaying 'null' as an output
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
> on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
