[
https://issues.apache.org/jira/browse/GEODE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026168#comment-16026168
]
ASF GitHub Bot commented on GEODE-2960:
---------------------------------------
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/541
GEODE-2960 : Trim field parameter values from create lucene index.
Added logic to trim leading and trailing spaces from values provided
against 'field'.
Modify existing test case to verify changes.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
Updated existing test.
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
No new dependency added.
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deepakddixit/incubator-geode bug/GEODE-2960
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/541.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #541
----
commit cd853456c2622412dbcb2cd0807be613070d1269
Author: Deepak Dixit <[email protected]>
Date: 2017-05-26T11:29:41Z
GEODE-2960 : Trim field parameter values from create lucene index.
Added logic to trim leading and trailing spaces from values provided
against 'field'.
Modify existing test case to verify changes.
----
> gfsh create index should trim from field names
> ----------------------------------------------
>
> Key: GEODE-2960
> URL: https://issues.apache.org/jira/browse/GEODE-2960
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Reporter: Jason Huynh
> Assignee: Deepak Dixit
>
> When creating an index with specific fields, the parameter expects a comma
> separated string. However we are not trimming after splitting the string.
> So if fields are defined as --field="name, age, height, weight" the indexed
> fields are actually "name", " age", " height", " weight"
> The command should probably trim the spaces before creating the index.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
