[
https://issues.apache.org/jira/browse/GEODE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024971#comment-16024971
]
ASF GitHub Bot commented on GEODE-2977:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/536
GEODE-2977: make group/name option values consistent
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode groupname
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/536.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #536
----
commit 01c5119654f27a254f8fb334b9fe8a2d5c4039ac
Author: YehEmily <[email protected]>
Date: 2017-05-23T19:27:40Z
GEODE-2977: make group/name option values consistent
----
> commands should take string[] as the value for --group and --memberId(--name)
> whenever possible
> -----------------------------------------------------------------------------------------------
>
> Key: GEODE-2977
> URL: https://issues.apache.org/jira/browse/GEODE-2977
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Jinmei Liao
>
> some commands takes string[], and some takes only String and split them
> manually. We should make this consistent and the help message would be a lot
> clearer if taking string[].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
