----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59544/ -----------------------------------------------------------
(Updated May 24, 2017, 10:10 p.m.) Review request for geode. Changes ------- Spotless Repository: geode Description ------- - Extract several commands into their own classes. - Extract utility methods into their own classes. - Rename AbstractCommandsSupport to GfshCommand, and convert it from an abstract class to an interface Diffs (updated) ----- geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 27bc098 geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java 2a1662e geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ce66057 geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 43ab546 geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a6d3064 geode-core/src/main/java/org/apache/geode/internal/Assert.java 4f54ca4 geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java 18fca98 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java 26b903b geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java 18940fc geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java 6d3f50f geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java b8ebc49 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java a38e545 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 4018beb geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 4232d91 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java bcbfcf0 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java ea10182 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java b824bc9 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java 2007e4a geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshHelpCommands.java da13cdf geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java a4ba64c geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 74acfd6 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java 415dd69 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java 0d714f4 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 0ce8ec2 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 6208adb geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java 561d4b8 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java ad344ff geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java 29627f3 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java feeb353 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java cbeee99 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java 78921c5 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/AssertJUnitTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 59d8a77 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 7fedb9f geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 9aeccad geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsJUnitTest.java e3a644d geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java PRE-CREATION geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 5e17f6e geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsJUnitTest.java 66e15bb Diff: https://reviews.apache.org/r/59544/diff/2/ Changes: https://reviews.apache.org/r/59544/diff/1-2/ Testing ------- Precheckin is running Thanks, Jared Stewart
