----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59492/ -----------------------------------------------------------
(Updated May 23, 2017, 9:54 p.m.) Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes ------- Extract methods to get at MXBeans into their own class. Rename SharedConfiguration -> ClusterConfiguration. Repository: geode Description ------- - Extract several commands out of LauncherLifecycleCommands into their distinct own classes. - Extract some utility methods from LauncherLifecycleCommands into more appropriate locations. Diffs (updated) ----- geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 27bc098 geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java 2a1662e geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ce66057 geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 12c5c21 geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a6d3064 geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java 18fca98 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java 26b903b geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java b6c11c4 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 68d055c geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfiguration.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java PRE-CREATION Diff: https://reviews.apache.org/r/59492/diff/2/ Changes: https://reviews.apache.org/r/59492/diff/1-2/ Testing ------- Precheckin running Thanks, Jared Stewart
