[ 
https://issues.apache.org/jira/browse/GEODE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020444#comment-16020444
 ] 

ASF GitHub Bot commented on GEODE-2956:
---------------------------------------

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/524

    GEODE-2956: Trimmed analzer strings in create index

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-2956

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #524
    
----
commit de702fd50f194990b0c6ad3ed4a7fddba9dd4e0a
Author: David Anuta <david.r.an...@gmail.com>
Date:   2017-05-23T00:10:25Z

    GEODE-2956: Trimmed analzer strings in create index

----


> gfsh lucene create index should trim from analyzer names
> --------------------------------------------------------
>
>                 Key: GEODE-2956
>                 URL: https://issues.apache.org/jira/browse/GEODE-2956
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Jason Huynh
>            Assignee: Jason Huynh
>
> When creating an index with specific analyzers, the parameter expects a comma 
> separated string.  However this comma separated string must have no spaces 
> before or after the comma.  If one exists, it attempts to find an analyzer 
> class with the starting or trailing whitespace. This leads to an even more 
> hard to read command.  
> The command should properly trim spaces before doing the class lookup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to