----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59426/#review175705 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On May 22, 2017, 10:34 a.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59426/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 10:34 a.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > During disk recovery the ConflictingPersistentDataException is not handled > properly; it should have logged an error and closed the cache. > When it is handled incorrectly, the cache is in inconsistent state; causing > other operations to fail in unexpected ways. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/cache/DiskAccessException.java > e77e485 > > geode-core/src/main/java/org/apache/geode/cache/persistence/ConflictingPersistentDataException.java > 9bf7234 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > e8daa18 > > geode-core/src/main/java/org/apache/geode/internal/cache/ProxyBucketRegion.java > 06378f2 > > geode-core/src/main/java/org/apache/geode/internal/cache/persistence/PersistenceAdvisorImpl.java > fc95f0b > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java > ba3444c > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java > ccdd38d > > > Diff: https://reviews.apache.org/r/59426/diff/1/ > > > Testing > ------- > > added new unit tests. > precheck started. > > > Thanks, > > anilkumar gingade > >
