----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59384/#review175533 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On May 19, 2017, 5:06 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59384/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 5:06 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick > Rhomberg. > > > Bugs: GEODE-1930 > https://issues.apache.org/jira/browse/GEODE-1930 > > > Repository: geode > > > Description > ------- > > I'm consistently seeing RegionManagementDUnitTest.testRegionAggregate fail in > verifySystemNotifications which is at the very end of the test. I think there > must be something async going on that we need to find and Await on. > > Until one of us has time to fix verifySystemNotifications, I'd like to > comment out that one line so we aren't seeing this fail every precheckin. > > I used GEODE-1930 which is a ticket to refactor the Management DUnit tests > because it's still open until we can finish refactoring the last couple > Management DUnit tests which includes RegionManagementDUnitTest. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java > 7dabd61d51f8598640537b661ecbb076b212cd0d > > > Diff: https://reviews.apache.org/r/59384/diff/1/ > > > Testing > ------- > > precheckin passed > > > Thanks, > > Kirk Lund > >
