[
https://issues.apache.org/jira/browse/GEODE-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016288#comment-16016288
]
ASF GitHub Bot commented on GEODE-2582:
---------------------------------------
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/520
GEODE-2582: New client can send a Put request with Protobuf IDL.
* Update the proto IDL
* Get a put request working.
Currently this only uses String serialization; serialization protocols
still have to be implemented.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
--> It does, except for `testRedundancySatisfactionPreferRemoteIp`, which
I have seen fail on my machine before for some reason related to my network
config.
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
@metatype can you verify that this license is compatible?
https://github.com/google/protobuf/blob/master/LICENSE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/geode feature/GEODE-2582
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #520
----
commit e7499a892e05fc6f2151310ea088261ffa4966af
Author: Galen OSullivan <[email protected]>
Date: 2017-03-16T23:26:03Z
GEODE-2582: New client can send a Put request with Protobuf IDL.
* Update the proto IDL
* Get a put request working.
Currently this only uses String serialization; serialization protocols
still have to be implemented.
----
> Prototype Protobuf Protocol: Client can send Put Request
> --------------------------------------------------------
>
> Key: GEODE-2582
> URL: https://issues.apache.org/jira/browse/GEODE-2582
> Project: Geode
> Issue Type: Sub-task
> Components: messaging
> Reporter: Addison
> Assignee: Galen O'Sullivan
>
> Using protobuf as the IDL for the [client-server
> protocol|https://cwiki.apache.org/confluence/display/GEODE/New+Client+Server+Protocol],
> GIVEN I'm a community developer writing a new client
> AND I was given some protofiles
> AND I have established a connection to the Gemfire server
> WHEN the client sends over a put message and some data
> THEN I should be able to see my data in the cache as *JSON*
> Out of scope:
> * Stats
> * PDX
> * Retry
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
