----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59242/#review175001 -----------------------------------------------------------
Apparently geode 1.1.1 was created from the develop branch and included the GFE_91 version that Barry created. In order for this fix to work I must create a new version in Version.java and change GMSMember to check for GFE_91. I'll rename Barry's GFE_91 to GEODE_111 when I do that work. - Bruce Schuchardt On May 12, 2017, 8:28 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59242/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 8:28 p.m.) > > > Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Bugs: GEODE-2915 > https://issues.apache.org/jira/browse/GEODE-2915 > > > Repository: geode > > > Description > ------- > > The fix for GEODE_2875 has exacerbated this problem, which we used to only > see in cases where disable-tcp=true or when multicast was enabled. > > The problem is that JGroupsMessenger is not sending the "vmkind" of the > sender in message headers. This part of the header comes from > GMSMember.writeEssentialData(). I've changed it here to include the vmKind > if the recipient isn't using geode 1.0, which doesn't expect the version byte. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java > 41c85d6421c8283163b70f2a560c8e4cbb02f2cc > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMember.java > b7079f8bc20a0e58949b69b9f0174a26af1a9b86 > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > 0476bbbfa4a1480d3b31a052e98dc62d9f0e3867 > > geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java > 85042da54f5a2a772d39ba450110073e14a30196 > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberJUnitTest.java > f471ad99b56615a1935ccf52127960f4af763d7d > > > Diff: https://reviews.apache.org/r/59242/diff/1/ > > > Testing > ------- > > new unit test. Precheckin is underway. I expect AnalyzeSerializables to > fail & will need to update its sanctionedDataSerializables.txt record for > GMSMember. > > > Thanks, > > Bruce Schuchardt > >
