----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59210/#review174740 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java Lines 219-220 (patched) <https://reviews.apache.org/r/59210/#comment247949> minor: extraneous blank lines geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java Lines 233 (patched) <https://reviews.apache.org/r/59210/#comment247950> Can't the newVesrion == null test be pulled outside the for loop? <pre> if (newVersion != null) { for ... } </pre> geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java Lines 409 (patched) <https://reviews.apache.org/r/59210/#comment247951> CollectionUtils.isEmpty(this.registeredFunctions) will handle the null case, and it's more concise. geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java Lines 129 (patched) <https://reviews.apache.org/r/59210/#comment248016> Put this in an @After block - Ken Howe On May 11, 2017, 9:47 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59210/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 9:47 p.m.) > > > Review request for geode. > > > Repository: geode > > > Description > ------- > > GEODE-2912: Hot deploy for functions in deployed Jars > > - New versions of a function now deploy over top the old versions without an > intermediate undeploy > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java > acb7d227a4f67c749cbc11ee2fdae8651d3bc5d6 > geode-core/src/main/java/org/apache/geode/internal/JarDeployer.java > df3f10b8cba9bdca8429bdcf8567b654d36ea475 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java > 697247701f883a5532ac0118ff116ac6562776d4 > > > Diff: https://reviews.apache.org/r/59210/diff/1/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >
