[ 
https://issues.apache.org/jira/browse/GEODE-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006470#comment-16006470
 ] 

ASF GitHub Bot commented on GEODE-265:
--------------------------------------

Github user metatype commented on the issue:

    https://github.com/apache/geode/pull/509
  
    Thanks for your contribution!
    
    If I'm reading the log correctly, `withArgs(IN args)` was deprecated one 
month ago.  We should *not* remove this from the public API until the next 
major version (e.g. 2.0.0).  In the future when we deprecate an API it would be 
helpful to mark *when* it was deprecated to help track this more explicitly.  
Can you remove this from the changeset?
    
    ```
    commit aaef124e3d4d7b46c82ddb4d2af65ee48b73ba53
    Author: Alyssa Kim <micro9...@gmail.com>
    Date:   Sat Apr 15 17:48:00 2017 -0700
    
        GEODE-728: Rename Execution.withArgs to Execution.setArguments
        
         * created setArguments
         * deprecated withArgs
         * implemented setArguments of all Execution implementations in Geode 
project
         * replaced all of withArgs with setArguments
        
        This closes #457
    ```


> Remove deprecated methods on Execution interface
> ------------------------------------------------
>
>                 Key: GEODE-265
>                 URL: https://issues.apache.org/jira/browse/GEODE-265
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Deepak Dixit
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The Execution interface has a number of execute methods that have been 
> deprecated. It looks like these could be easily removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to