[
https://issues.apache.org/jira/browse/GEODE-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006350#comment-16006350
]
ASF GitHub Bot commented on GEODE-2890:
---------------------------------------
Github user ameybarve15 commented on the issue:
https://github.com/apache/geode/pull/505
Can I merge this PR ?
> Incorrect debug log location in
> AbstractGatewaySenderEventProcessor.processQueue()
> -----------------------------------------------------------------------------------
>
> Key: GEODE-2890
> URL: https://issues.apache.org/jira/browse/GEODE-2890
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Jason Huynh
> Assignee: Amey Barve
>
> The following code snippet in processQueue() for AEQ's appears to be outside
> of an if condition where we check to see if the node is primary still or not.
> This line prints for every event and I believe it should be inside the
> previous if condition.
> {noformat}
> if (qpr != null) {
> BucketRegion bucket = qpr.getDataStore().getLocalBucketById(bucketId);
> if (bucket == null || !bucket.getBucketAdvisor().isPrimary()) {
> event.setPossibleDuplicate(true);
> //I think the debug log should be placed here?
> }
> }
> if (isDebugEnabled) {
> logger.debug( "Bucket id: {} is no longer primary on this node. The event
> {} will be dispatched from this node with possibleDuplicate set to true.",
> bucketId, event);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
