[ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003737#comment-16003737
 ] 
ASF GitHub Bot commented on GEODE-2907:
---------------------------------------

Github user upthewaterspout commented on a diff in the pull request:

    https://github.com/apache/geode/pull/503#discussion_r115623920
  
    --- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
    @@ -37,21 +42,38 @@
      * Results are returned in order of their score with respect to this query.
      * </p>
      */
    -@Experimental
     public interface LuceneQuery<K, V> {
       /**
        * Execute the query and return the region keys that match this query, 
up to the limit specified
        * by {@link #getLimit()}.
    -   * 
    +   *
    +   * @return Collection of Apache Geode region keys that satisfy the 
Lucene query.
        * @throws LuceneQueryException if the query could not be parsed or 
executed.
    +   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
    +   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
    --- End diff --
    
    PrimaryBucketException is an internal exception, which should not be part 
of the API. Do we actually throw this exception from this method? It seems like 
we should be retrying in any case.


> Remove @Experimental tag from the Lucene module
> -----------------------------------------------
>
>                 Key: GEODE-2907
>                 URL: https://issues.apache.org/jira/browse/GEODE-2907
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: nabarun
>            Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to