[
https://issues.apache.org/jira/browse/GEODE-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001394#comment-16001394
]
ASF GitHub Bot commented on GEODE-254:
--------------------------------------
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/488#discussion_r115331339
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java
---
@@ -187,7 +187,7 @@ public void destroyRegion(Object callbackArgument)
throws CacheWriterException,
public Set entries(boolean recursive) {
--- End diff --
I think it is wrong to keep these methods your are removing from Region on
classes that implement the Region interface. It is too bad that these impls did
not have @Override on them because that would have caused compilation failures.
> Remove deprecated Region.keys and Region.entries
> ------------------------------------------------
>
> Key: GEODE-254
> URL: https://issues.apache.org/jira/browse/GEODE-254
> Project: Geode
> Issue Type: Sub-task
> Reporter: Darrel Schneider
> Assignee: Avinash Dongre
> Fix For: 1.2.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Remove the deprecated Region.keys and Region.entries. Any calls can be simply
> changed to Region.keySet and Region.entrySet so this should be an easy change.
> A large number of tests call the deprecated methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
