----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59057/ -----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. Bugs: GEODE-2193 https://issues.apache.org/jira/browse/GEODE-2193 Repository: geode Description ------- The previous fix for this ticket introduced a shutdown problem that caused servers to pause waiting for ShutdownMessage to be sent to another server that had already exited. We reduced the pause time but this change set fixes the problem by transmitting the message over UDP instead of TCP/IP stream sockets. Another change in GMSJoinLeave prepareView/sendView allows a membership coordinator that is shutting down to complete the sending out of a new view if it has already prepared the view when shutdown begins. Diffs ----- geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java df880a076739509fe48394dd224ae2ea33c60dd5 geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java e0c0ba29a5c74614d2430fb78d972e306a355845 geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 8ae66d0b6839cfbd46b479d896104f54fd11a68d geode-core/src/main/java/org/apache/geode/internal/util/PluckStacks.java 357812a6ec0cb09a88fa727a4bf828f18794264d Diff: https://reviews.apache.org/r/59057/diff/1/ Testing ------- precheckin plus 1000 runs of the test that was hitting this issue at least 4% of the time Thanks, Bruce Schuchardt