----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59034/#review174093 -----------------------------------------------------------
Ship it! Ship It! - Joey McAllister On May 5, 2017, 10:32 p.m., Dave Barnes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59034/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 10:32 p.m.) > > > Review request for geode, Hitesh Khamesra, Joey McAllister, and Pulkit > Chandra. > > > Repository: geode > > > Description > ------- > > GEODE-2352 Document that REST API requires two properties > > > Diffs > ----- > > geode-docs/rest_apps/chapter_overview.html.md.erb > 5e48675b7eba37ae3f6cd078111c0acf09d9ae68 > geode-docs/rest_apps/rest_prereqs.html.md.erb > 935f94b2caf83478bd0ac97dc797ccdcee695b8c > geode-docs/rest_apps/setup_config.html.md.erb > 71c50f53dbc080f9d973b268eade9cb03c05e746 > > > Diff: https://reviews.apache.org/r/59034/diff/1/ > > > Testing > ------- > > The two properties, `http-service-bind-address` and `http-service-port`, are > not *mandatory* as stated in the ticket, but if allowed to default, they may > not be publicly visible. So we'll say they're optional, but that it's *good > practice* to specify them for visibility. > This checkin also picks up some other corrections regarding API library name > and some format fixes. > > > Thanks, > > Dave Barnes > >
