----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58853/#review173472 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java Lines 321 (patched) <https://reviews.apache.org/r/58853/#comment246468> All recordBulkOpEvent method call is to put a version tag of an entryEvent. There is no need to record if concurrency check is not enabled. geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java Line 548 (original), 551 (patched) <https://reviews.apache.org/r/58853/#comment246538> Use a while loop to make sure it is not null. geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java Line 552 (original), 555 (patched) <https://reviews.apache.org/r/58853/#comment246470> As long as opSyncObj.getStatus() returns false, the else statement will be executed. geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java Line 685 (original), 689 (patched) <https://reviews.apache.org/r/58853/#comment246539> Removed the test method, as it is being used by wan in the product -- even though my changes no longer call this method. geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java Line 6202 (original), 6213 (patched) <https://reviews.apache.org/r/58853/#comment246540> No longer using getEventTracker() call in the code so that the refactoring will be easier to do later to set the eventTracker field to be final. - Eric Shu On May 2, 2017, 1 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58853/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 1 a.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-2847 > https://issues.apache.org/jira/browse/GEODE-2847 > > > Repository: geode > > > Description > ------- > > Get correct version tags from recordedBulkOpVersionTags in eventTracker. > Do not remove the recordedBulkOpVersionTags prematurely. > Add the unit test which would fail without the fixes. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java > 2ddfdc4 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 8c061b0 > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutAllPRMessage.java > 27f5aa0 > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java > f4f6299 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProxyMembershipID.java > 2cbf63b > > geode-core/src/test/java/org/apache/geode/internal/cache/AbstractDistributedRegionJUnitTest.java > ba2f794 > > geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionJUnitTest.java > 7525f35 > > geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58853/diff/2/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
