Jared Stewart created GEODE-2842:
------------------------------------
Summary: Remove unnecessary @CliOption arguments
Key: GEODE-2842
URL: https://issues.apache.org/jira/browse/GEODE-2842
Project: Geode
Issue Type: Bug
Components: gfsh
Reporter: Jared Stewart
The {{@CliOption}} annotation specifies default values for some of its fields
(like {{mandatory}} and {{unspecifiedDefaultValue}}). Yet, we often explicitly
set those fields to the default value. For example,
{noformat} @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME,
mandatory = false,
unspecifiedDefaultValue = CliMetaData.ANNOTATION_NULL_VALUE,
help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String memberName
{noformat}
could simply read
{noformat} @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME,
help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String memberName
{noformat}
Removing these redundant/unnecessary arguments will make the code a lot more
readable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
