----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58813/#review173279 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java Line 2352 (original), 2357 (patched) <https://reviews.apache.org/r/58813/#comment246316> I think this code needs to also update clientEvent by calling rs.getVersionStamp().asVersionTag() - Darrel Schneider On April 27, 2017, 12:44 p.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58813/ > ----------------------------------------------------------- > > (Updated April 27, 2017, 12:44 p.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > When client does a get() which results in adding an entry by calling loader > on server side, the client event returned back is not updated with the > version tag that is created with the new entry on server. This results in > client having a different version tag than the server side entry. If client > has registered event, and is concurrently updating the entry (from get() call > and an register-event from server), it could result in data consistency > between client and server. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java > 8cdc517 > > geode-core/src/test/java/org/apache/geode/internal/cache/AbstractDistributedRegionJUnitTest.java > ba2f794 > > geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionJUnitTest.java > 7525f35 > > > Diff: https://reviews.apache.org/r/58813/diff/1/ > > > Testing > ------- > > Manual testing. > Running new unit test (added) with and without changes. > precheckin in progress. > > > Thanks, > > anilkumar gingade > >
