[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985589#comment-15985589
 ] 

ASF GitHub Bot commented on GEODE-2828:
---------------------------------------

Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/479#discussion_r113565230
  
    --- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 ---
    @@ -166,28 +166,28 @@ public void createIndex(final String indexName, 
String regionPath, final Analyze
        * 
        * Public because this is called by the Xml parsing code
        */
    -  public void afterDataRegionCreated(final String indexName, final 
Analyzer analyzer,
    -      final String dataRegionPath, final Map<String, Analyzer> 
fieldAnalyzers,
    -      final String... fields) {
    -    LuceneIndexImpl index = createIndexRegions(indexName, dataRegionPath);
    -    index.setSearchableFields(fields);
    -    index.setAnalyzer(analyzer);
    -    index.setFieldAnalyzers(fieldAnalyzers);
    +  public void afterDataRegionCreated(LuceneIndexImpl index) {
         index.initialize();
         registerIndex(index);
         if (this.managementListener != null) {
           this.managementListener.afterIndexCreated(index);
         }
    +
    +  }
    +
    +  public LuceneIndexImpl beforeDataRegionCreated(final String indexName, 
final String regionPath,
    +      RegionAttributes attributes, final Analyzer analyzer,
    +      final Map<String, Analyzer> fieldAnalyzers, String aeqId, final 
String... fields) {
    +    LuceneIndexImpl index = createIndexRegions(indexName, regionPath);
    --- End diff --
    
    This wasn't introduced with this diff, but we probably want to rename this 
method.  I don't think the method is creating any index regions.  I think it's 
just creating the index object but none of the file/chunk or aeq region or 
buckets


> AEQ needs to be created before the user region
> ----------------------------------------------
>
>                 Key: GEODE-2828
>                 URL: https://issues.apache.org/jira/browse/GEODE-2828
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to