----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58722/#review173010 -----------------------------------------------------------
Ship it! Ship It! - anilkumar gingade On April 25, 2017, 10:36 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58722/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 10:36 p.m.) > > > Review request for geode, anilkumar gingade, Eric Shu, and Lynn Gallinat. > > > Bugs: GEODE-2811 > https://issues.apache.org/jira/browse/GEODE-2811 > > > Repository: geode > > > Description > ------- > > Closing the cache now closes the off-heap evictor. > > Rejected executions are now ignored if shutting down. > The execute method is now used instead of submit in the HeapEvictor. > Close logic on HeapEvictor improved to prevent race conditions and NPEs. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 56243e1b544f5958204e64c2ca391003aa1fd098 > > geode-core/src/main/java/org/apache/geode/internal/cache/RegionEvictorTask.java > da6a671b46c658124ff699d55508e38d7772eac4 > > geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapEvictor.java > b22bb0ec5fa5938a23bad015cf02b9295631bfed > > geode-core/src/test/java/org/apache/geode/internal/cache/EvictionTestBase.java > fe86910ba931287fe20f4fd747d608e517d5c718 > > geode-core/src/test/java/org/apache/geode/internal/cache/GemFireCacheImplTest.java > 6838e748f112d05363185b7a7e28dd4ce08f80c9 > > > Diff: https://reviews.apache.org/r/58722/diff/1/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
